DCJ-676: Remove setupProxy and http-proxy-middleware #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjohanek
reviewed
Sep 17, 2024
DEVNOTES.md
Outdated
| 3. Install configs for an environment. This example is for the `alpha` environment, but you can use values from any environment by looking at the deployed configs in https://duos-k8s.dsde-{%ENV%}.broadinstitute.org/config.json where {%ENV%} is any of `dev`, `staging`, `alpha`, or `prod` | ||
| Remember to set the `env` value appropriately. We use `local` for running via npm, but under docker, we use a real env like `dev`. | ||
| 3. Install configs for an environment. This example is for the `alpha` environment, but you can use values from any environment by looking at the deployed configs in https://duos-k8s.dsde-{%ENV%}.broadinstitute.org/config.json where {%ENV%} is any of `dev`, `staging`, `alpha`, or `prod` | ||
| Remember to set the `env` value appropriately, for example, `dev`. Certain features are not available on different environments and this will simulate that for local development. |
There was a problem hiding this comment.
is the point here that we want to point to dev backend for local development? Does "this" in this sentence refer to dev? This is a little unclear to me
There was a problem hiding this comment.
Thanks for the question Rae! this refers to the env variable. I'll take another stab at this language.
rjohanek
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-676
Summary
This PR removes unnecessary configurations for local development.
Have you read Terra's Contributing Guide lately? If not, do that first.