Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-155: Move sign in button from the home page body to the navigation bar #2658

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Aug 30, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-155

Summary

Minor refactor of the sign in button placement from the body of the home page to the navigation bar. There are no functional differences - this is purely a button rearrangement. However, when the window size is reduced, this means that sign-in is now an element in the right-side panel whereas previously, it was hidden, so this PR adds a small degree of functionality.

Full Screen

The window on top is current dev, the window on the bottom is the new version.

Screenshot 2024-08-30 at 7 32 04 AM

Reduced Window Size

The window on the left is dev, the window on the right is new.

Screenshot 2024-09-03 at 7 19 39 AM


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review August 30, 2024 11:48
@rushtong rushtong requested a review from a team as a code owner August 30, 2024 11:48
@rushtong rushtong requested review from fboulnois and okotsopoulos and removed request for a team August 30, 2024 11:48
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, on reduced sized screens we may want to have it as part of the navbar items instead of the bottom 👍

Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@rushtong rushtong merged commit c136a0d into develop Sep 4, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-155-move-sign-in-button branch September 4, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants