Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-542: Fully deprecate old dataset registration page #2635

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Jul 25, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-542

Summary

Fully remove the old dataset registration page. We have migrated all production datasets to studies. In the one case where there was an edit link for datasets, instead we only link for the case where the dataset has a study. This is evident in dev, but not in other environments. Note the missing pencil icon for DUOS-000621 which doesn't have a study.

Screenshot 2024-07-25 at 3 32 08 PM


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review July 25, 2024 19:34
@rushtong rushtong requested a review from a team as a code owner July 25, 2024 19:34
@rushtong rushtong requested review from fboulnois and aarohinadkarni and removed request for a team July 25, 2024 19:34
@rushtong rushtong changed the title DCJ-542: fully deprecate old dataset registration page DCJ-542: Fully deprecate old dataset registration page Jul 26, 2024
@rushtong rushtong requested review from okotsopoulos and removed request for aarohinadkarni July 29, 2024 12:32
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's massive!

@rushtong rushtong merged commit bdfd380 into develop Jul 30, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-542-rm-old-dataset-registration branch July 30, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants