Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCJ-519: Log data library page views #2633

Merged
merged 2 commits into from
Jul 25, 2024
Merged

DCJ-519: Log data library page views #2633

merged 2 commits into from
Jul 25, 2024

Conversation

rushtong
Copy link
Contributor

@rushtong rushtong commented Jul 25, 2024

Addresses

Partially addresses https://broadworkbench.atlassian.net/browse/DCJ-519

See also: #2634

Summary

When visiting the Data Library page, log mix panel events. This will create a different event for each branded view the user visits. When testing, navigate to any of the various flavors of the data library and you should see network calls go out to terra-bard. The events are logged in the dev mixpanel project here.

Screenshot 2024-07-25 at 7 58 24 AM


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review July 25, 2024 12:03
@rushtong rushtong requested a review from a team as a code owner July 25, 2024 12:03
@rushtong rushtong requested review from fboulnois and aarohinadkarni and removed request for a team July 25, 2024 12:03
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍

Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 👍

@rushtong rushtong merged commit 4c00bf6 into develop Jul 25, 2024
9 checks passed
@rushtong rushtong deleted the gr-DCJ-519-mixpanel branch July 25, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants