Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-48] Make the DAR dataset selection remove only after draft DAR creation #2622

Conversation

aarohinadkarni
Copy link
Contributor

@aarohinadkarni aarohinadkarni commented Jul 11, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-48

Summary

These changes replace the selection form field in the DAR form with a static display of the datasets that were selected with the option to delete the dataset from the DAR, but no longer add anymore datasets to the DAR form after creation of the DAR. If all datasets are deleted but one, the last remaining dataset is non-deletable. This "static" functionality of the DAR form is also only available in dev environments.

Examples

DAR form with multiple dataset selections:
Screenshot 2024-07-18 at 1 32 47 PM

DAR form with some datasets selected for removal:
Screenshot 2024-07-18 at 1 33 00 PM

DAR form with all but one dataset selected for removal:
Screenshot 2024-07-18 at 1 33 04 PM

Read-only view visible to Admins and DAC Members:
Screenshot 2024-07-18 at 1 37 52 PM


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@aarohinadkarni aarohinadkarni marked this pull request as ready for review July 12, 2024 14:58
@aarohinadkarni aarohinadkarni requested a review from a team as a code owner July 12, 2024 14:58
@aarohinadkarni aarohinadkarni requested review from rushtong and okotsopoulos and removed request for a team July 12, 2024 14:58
@rushtong rushtong requested review from fboulnois and removed request for rushtong July 18, 2024 18:56
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below:

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great!

@rushtong rushtong merged commit e3c6640 into develop Jul 29, 2024
9 checks passed
@rushtong rushtong deleted the an-DCJ-48-UI-Due-to-DAA-restrictions-make-the-DAR-dataset-selection-read-only-after-creation branch July 29, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants