-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DCJ-48] Make the DAR dataset selection remove only after draft DAR creation #2622
Merged
rushtong
merged 24 commits into
develop
from
an-DCJ-48-UI-Due-to-DAA-restrictions-make-the-DAR-dataset-selection-read-only-after-creation
Jul 29, 2024
Merged
[DCJ-48] Make the DAR dataset selection remove only after draft DAR creation #2622
rushtong
merged 24 commits into
develop
from
an-DCJ-48-UI-Due-to-DAA-restrictions-make-the-DAR-dataset-selection-read-only-after-creation
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarohinadkarni
requested review from
rushtong and
okotsopoulos
and removed request for
a team
July 12, 2024 14:58
…ctions-make-the-DAR-dataset-selection-read-only-after-creation
fboulnois
reviewed
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See below:
fboulnois
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great!
okotsopoulos
approved these changes
Jul 29, 2024
rushtong
deleted the
an-DCJ-48-UI-Due-to-DAA-restrictions-make-the-DAR-dataset-selection-read-only-after-creation
branch
July 29, 2024 17:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-48
Summary
These changes replace the selection form field in the DAR form with a static display of the datasets that were selected with the option to delete the dataset from the DAR, but no longer add anymore datasets to the DAR form after creation of the DAR. If all datasets are deleted but one, the last remaining dataset is non-deletable. This "static" functionality of the DAR form is also only available in dev environments.
Examples
DAR form with multiple dataset selections:
DAR form with some datasets selected for removal:
DAR form with all but one dataset selected for removal:
Read-only view visible to Admins and DAC Members:
Have you read Terra's Contributing Guide lately? If not, do that first.