Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-427] Update micromatch to 4.0.7 to address vulnerability #2608

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

fboulnois
Copy link
Contributor

@fboulnois fboulnois commented Jun 24, 2024

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-427

Summary

Micromatch dependency is vulnerable to Regular Expression Denial of Service (ReDoS). This is fixed in versions >4.0.6.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner June 24, 2024 17:02
@fboulnois fboulnois requested review from rushtong and okotsopoulos and removed request for a team June 24, 2024 17:02
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 👍🏽

Copy link
Contributor

@aarohinadkarni aarohinadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you! 👍

Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fboulnois fboulnois merged commit 14ab51e into develop Jun 26, 2024
9 checks passed
@fboulnois fboulnois deleted the fb-dcj-427-micromatch-update branch June 26, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants