-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DCJ-71] Create page to edit DAC #2598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Is there any support available in this codebase for component tests? Especially cases where the underlying algorithm is so involved as to benefit from comments (thanks for those!). I could see those benefitting from repeated verification in tests.
@okotsopoulos I'm pretty sure there is support available for component tests! Personally I haven't written any in this repo, but I can investigate. |
After discussing in standup, I've created this ticket to write a test for this component: https://broadworkbench.atlassian.net/browse/DCJ-405. |
Addresses
https://broadworkbench.atlassian.net/browse/DCJ-71
Summary
Takes content of the Edit DAC action on the DAC Chair Console into a new page for each DAC found at a new
/manage_edit_dac/{dacId}
route.Have you read Terra's Contributing Guide lately? If not, do that first.