Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-71] Create page to edit DAC #2598

Merged
merged 11 commits into from
May 30, 2024

Conversation

aarohinadkarni
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-71

Summary

Takes content of the Edit DAC action on the DAC Chair Console into a new page for each DAC found at a new /manage_edit_dac/{dacId} route.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@aarohinadkarni aarohinadkarni changed the title An dcj 71 page ify manage dac page [DCJ-71] Create page to edit DAC May 21, 2024
@aarohinadkarni aarohinadkarni marked this pull request as ready for review May 21, 2024 19:38
@aarohinadkarni aarohinadkarni requested a review from a team as a code owner May 21, 2024 19:38
@aarohinadkarni aarohinadkarni requested review from fboulnois and okotsopoulos and removed request for a team May 21, 2024 19:38
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👍

Copy link
Contributor

@okotsopoulos okotsopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Is there any support available in this codebase for component tests? Especially cases where the underlying algorithm is so involved as to benefit from comments (thanks for those!). I could see those benefitting from repeated verification in tests.

src/pages/manage_dac/ManageEditDac.jsx Outdated Show resolved Hide resolved
@aarohinadkarni
Copy link
Contributor Author

Is there any support available in this codebase for component tests? Especially cases where the underlying algorithm is so involved as to benefit from comments (thanks for those!). I could see those benefitting from repeated verification in tests.

@okotsopoulos I'm pretty sure there is support available for component tests! Personally I haven't written any in this repo, but I can investigate.

@aarohinadkarni
Copy link
Contributor Author

I'm pretty sure there is support available for component tests! Personally I haven't written any in this repo, but I can investigate.

After discussing in standup, I've created this ticket to write a test for this component: https://broadworkbench.atlassian.net/browse/DCJ-405.

@aarohinadkarni aarohinadkarni merged commit 8f508ac into develop May 30, 2024
9 checks passed
@aarohinadkarni aarohinadkarni deleted the an-DCJ-71-page-ify-manage-dac-page branch May 30, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants