[DCJ-58] Update DAR application to indicate all required DAAs

[aarohinadkarni]

Addresses

https://broadworkbench.atlassian.net/browse/DCJ-58

Summary

Shows all required DAAs for datasets in a DAR in the Data Use Agreement section of the DAR application instead of the "default" Broad & NHGRI LCAs. In the case that a DAR only consists of datasets that are "Open Access" or "External to DUOS," we are currently showing the DUOS Code of Conduct/DAA. This may change after conversations with Jonathan, but this is what was decided for now.

---

Have you read Terra's Contributing Guide lately? If not, do that first.

• Label PR with a Jira ticket number and include a link to the ticket
• Label PR with a security risk modifier [no, low, medium, high]
• PR describes scope of changes
• Get a minimum of one thumbs worth of review, preferably two if enough team members are available
• Get PO sign-off for all non-trivial UI or workflow changes
• Verify all tests go green
• Test this change deployed correctly and works on dev environment after deployment

[rushtong]

This works as expected. I have some questions inline, and I think we need to clarify some edge cases.

[rushtong]

I have a functional question here. Even if my user does NOT have a LC-DAA association, I still see the linked data access agreement in my DAR. Is that correct? I'm not sure we've thought this use case through yet.

[rushtong]

See comments inline - I think we need to address a release strategy before merging this.

[fboulnois]

Holding off on review until we resolve Greg's concern.

[aarohinadkarni]

I have a functional question here. Even if my user does NOT have a LC-DAA association, I still see the linked data access agreement in my DAR. Is that correct? I'm not sure we've thought this use case through yet.

@rushtong I believe that future work (DCJ-49 and DCJ-47) should ensure that if you don't have the LC-DAA association for the DAA that governs a dataset, you should not be able to get to this screen where you would be opening a DAR against that dataset.

[rushtong]

@rushtong I believe that future work (DCJ-49 and DCJ-47) should ensure that if you don't have the LC-DAA association for the DAA that governs a dataset, you should not be able to get to this screen where you would be opening a DAR against that dataset.

Thank you, that's helpful. This means that during the time between SO's creating LC-DAA associations, users will see the DAAs for datasets even though they don't have any and their SOs will not have created any. It also means that if an SO purposefully does NOT create an LC-DAA association for a user, the user will still see it.

As part of the release strategy, I think we need to work on some kind of data population process that creates these for users with open DARs.

[aarohinadkarni]

As part of the release strategy, I think we need to work on some kind of data population process that creates these for users with open DARs.

This makes sense— let's discuss with the team.

[rushtong]

Tested locally with checkEnv('staging') which works as expected.

[fboulnois]

lgtm 👍

[rushtong]

👍🏽 Thank you for the updates!