Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExportFab back in #102

Merged
merged 3 commits into from
Jul 17, 2018
Merged

Add ExportFab back in #102

merged 3 commits into from
Jul 17, 2018

Conversation

alahwa
Copy link
Contributor

@alahwa alahwa commented Jul 17, 2018

No description provided.

@alahwa alahwa requested a review from melissachang July 17, 2018 17:51
@melissachang
Copy link
Contributor

I get this error when I run docker-compose up --build locally:

ui_1               | Failed to compile.
ui_1               | 
ui_1               | ./src/components/ExportFab.js
ui_1               | Module not found: Can't resolve '@material-ui/core/Button' in '/ui/src/components'

I'm not sure how CircleCI passed -- maybe something to do with node_modules caching?

Can you try to repro this error? Things you can try:

  • fresh git clone
  • deleting containers on your computer

@alahwa
Copy link
Contributor Author

alahwa commented Jul 17, 2018

I ran into the same issue, it's actually a really annoying bug with docker's image caching forcing us to restart when we add new packages. I don't know why even --build and --force-recreate don't do the trick here. Try deleting your existing data explorer images (I just wiped all of my cached images/volumes/containers via docker system prune) and re-building.

@melissachang
Copy link
Contributor

Can you please share any links that you found in your investigation?

@alahwa
Copy link
Contributor Author

alahwa commented Jul 17, 2018

docker/compose#4337

@melissachang
Copy link
Contributor

Strange. I did docker system prune and things worked for me also.

The problem was with npm itself. When I saw the problem, if I docker exec into container and run npm install, there is no node_modules/@material-ui/core/Button. If we keep seeing npm problems, we might consider switching to yarn.

@alahwa
Copy link
Contributor Author

alahwa commented Jul 17, 2018

I'm still not sure whether that's an npm problem or not. It's possible the package.json and package-lock.json being copied into the docker container at runtime are coming from a stale cache and not the updated versions, which would be a docker problem. Still, agreed we should keep an eye out for this.

@alahwa alahwa merged commit 95b0bd4 into master Jul 17, 2018
@melissachang
Copy link
Contributor

package.json/package-lock.json were correct, it's an npm problem.

@alahwa alahwa deleted the ah/firecloud_ui branch July 17, 2018 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants