Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCJ-627][risk=low] Remove deprecated Dataset needsApproval and active state attributes from consent service and database #2399

Merged

Conversation

otchet-broad
Copy link
Contributor

Addresses

Addresses the consent and database portion of removing deprecated Dataset properties

Summary

Removes properties and related getters/setters from Dataset class, DTOs
Removes columns from SQL queries
Adds liquidbase script to drop the columns from the dataset table

See Also:

DataBiosphere/duos-ui#2663

Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍🏽

Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@otchet-broad
Copy link
Contributor Author

Thanks!

@otchet-broad otchet-broad merged commit 8ffe683 into develop Sep 12, 2024
14 checks passed
@otchet-broad otchet-broad deleted the otchet/DCJ-627_removed_deprecated_dataset_attributes branch September 12, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants