Bug fix: Unable to display images when the path contains Chinese characters #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 97.75% 97.75%
=======================================
Files 10 10
Lines 623 624 +1
Branches 89 89
=======================================
+ Hits 609 610 +1
Misses 9 9
Partials 5 5 ☔ View full report in Codecov by Sentry. |
|
I don't know if this is the best way to go about this since what we're really doing here is using os.fsencode(), urllib.parse.quote_from_bytes(), and them immediately unquoting, but it passes the tests and seems to work fine. Merging. |
DatGuy1
added a commit
that referenced
this pull request
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using URL encoding will cause Chinese characters to display as garbled text, making it impossible to correctly display images with Chinese file paths. By using the urllib.parse.unquote() method to restore the garbled URL, the Chinese characters can be displayed properly.