Fix gaps seeking #4068
Merged
Fix gaps seeking #4068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to fix a regression introduced in PR #3928, and described in issue #4067
When jumping gap since audio timeline starts after video timeline, the DashHandler::getValidTimeAheadOfTargetTime() consider next 1st audio segment start time as seeking time.
Due to PR #3928 that fixes rounding issues in TimelineSegmentsGetter, searching segment at 1st audio segment start time fails and playback dails to start.
This PR proposes a fix by adding a delta value to founded segment start time to get around the rounding issues.