-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dash handler optimizations #3727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dash.js into feature/dashHandlerOptimizations
…od have been requested
@lkinasiewicz Can you please check if this solves the prebuffering issue you saw with your multiperiod content |
Yes, this fixes the problem. I removed my changes from this area in #3718. |
…dash.js into feature/dashHandlerOptimizations
…dash.js into feature/dashHandlerOptimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve parts of #3713. It includes a new logic in the DashHandler to decide whether all segments of a period have been loaded:
BufferController
. After appending each segment we check if the current buffer is >= the time until the end of the period.The advantage of the new approach is that we start prebuffering new periods, even if not enough segments are signaled to fill the whole buffer for the current period.