-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow setInitialMediaSettingsFor with fragmentedText media type #3245
allow setInitialMediaSettingsFor with fragmentedText media type #3245
Conversation
@dsilhavy Note that today, dash.js player enables text by default if any. Moreover, localStorage is actually used to store audio and video media settings. |
b06acf3
to
d7b4d24
Compare
@jeffcunat Thanks for this PR, I added some minor comments. In addition:
|
I will provide another PR soon for keeping text settings in local storage. |
Perfect, thanks |
This PR will make setInitialMediaSettingsFor compatible with fragmentedText (like it is done with audio and video)
For example :
This is useful to initialize the player for users that want to activate closed captions by default if they are present.
We are using the mediaController.matchSettings method inside the TextController to reuse the same mechanism than for audio and video.
We can keep the setTextDefaultLanguage method for backward compatibility but
player.setInitialMediaSettingsFor('fragmentedText', { lang: 'en' });
is equivalent toplayer.setTextDefaultLanguage('en')