Refactoring #2898
Merged
Refactoring #2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosang
force-pushed
the
refactoring
branch
3 times, most recently
from
54b97ea to
1037bee
Compare
…uest, getIndexhandlerTime, setIndexhandlerTime and resetIndexHandler functions
add getRealAdaptation and getVoRepresentations functions remove unused getDataIndex function in RepresentationController remove dashManifestModel reference in RepresentationController update unit tests.
update ThumbnailTracks and unit tests
add getSuggestedPresentationDelay and getAvailabilityStartTime functions
…t functions in dashAdapter
- test e.oldQuality !== e.newQuality is already done before this event is triggered => remove it in callback - call setSaveBitrateSettings in AbrController => get and set functions of bitrates are called in the same class (AbrController)
…period transition, so droppedFramesHistory, throughputHistory and switchHistoryDict are already created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR is the following step of PR #2881. The main idea is to only use DashAdapter class in all Dash.js classes as a facade instead of DashAdapter and DashManifestModel. In this PR, the DashManifestModel is only used by DashAdapter. Another work to do will be to clearly define the responsibility of both classes....
Nico