Fix #1759 (regression) resume correctly after seek #1761
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1759 caused by 930717e.
Original reason for 930717e was a problem were segment lists were updated out of order such that the previously fetched index was sometimes no longer valid. For instance, if a paused player drifted outside of the rewind window, when seeking back, the
getSegmentByIndex
andgetIndexForSegments
functions would be using different segment lists.Moving
updateSegments
fixed the issue, but caused problems for other streams where the segment list needs to be updated on everygetSegmentRequestForTime
call.6650178 now works, but the whole thing could probably do with refactoring and the first
updateSegments
should probably go somewhere else.