New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix initial textrack display mode loop #1725

Merged

dsparacio merged 1 commit into Dash-Industry-Forum:development from Afrostream:fixInitCaptionsLoop

Dec 29, 2016

Contributor

benjipott commented Dec 29, 2016 •

edited

Loading

The loop initializing the subtitles uses a variable undefined
So the subtitles are not visible when the player start


          fix initial textrack diplay mode loop

548c603

Contributor

dsparacio commented Dec 29, 2016

Thank you. So sorry for causing this one. Late PR into late release and I rushed it.

Odd thing is I tested with the subtitle test streams in this player
http://dashif.org/reference/players/javascript/v2.4.0/samples/dash-if-reference-player/index.html
it showed first track so I missed this . Must be something in control bar calling setTextTrack...

Ugh

dsparacio merged commit 0618762 into Dash-Industry-Forum:development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet