-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix replaying of content in Firefox #1009
Conversation
Sorry, think I managed to miss this comment. I've just tried the sample MPDs above with this branch in Firefox and Chrome:
None of the streams with captions in FF show the CC option in the UI so there is no way to verify them. |
mpd 2 and 3 play correctly for me with Firefox 43–46 on OS X 10.11 and Windows 10. |
http://vm2.dashif.org/livesim-dev/utc_direct-head/testpic_2s/Manifest.mpd Can you test this as well. No UI for CC means not text tracks added to video element which means there is either an issue with TextTracks in Firefox... Ill check it out today |
I don't think timed text captions are supported in Firefox. |
@cpeterso we manually handle all of that as it is not supported by MSE in any browser at this time. It is a simple function on the video element. We parser and create tracks and append to element track list. |
I am going to pull this in but seems like needs a rebase. Please do and Ill pull in and test TT stuff. |
f11fc0f
to
8d1fab2
Compare
Clean and now ready to merge. Lost the MPD list comment: I can't remember why this was here but it was here for something very specific and now that it has been removed I am not sure what it will break but pretty sure it will break something ;) I think fragmented text tracks... How many content permutations did you test after you removed this line? Here are a few streams with text tracks that I have been smoke testing with. May help. http://vm2.dashif.org/livesim-dev/testpic_2s/Manifest.mpd |
@cpeterso @LloydW93 So this is interesting my comment on video element and adding tracks vs source buffer support via MSE for Timed Text may not be accurate. Seems like the issue si in firefox on the video element itself. It is not allowing us to add tracks. So like IE we may need a special work around for this. I will file a new bug. |
Fix replaying of content in Firefox
Steps to reproduce issue:
Expected behaviour:
Playback restarts from the beginning of the media
Actual behaviour:
Playback never starts