Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOMStoarge Last Bitrate Broken #1115

Closed
dsparacio opened this issue Feb 3, 2016 · 2 comments
Closed

DOMStoarge Last Bitrate Broken #1115

dsparacio opened this issue Feb 3, 2016 · 2 comments
Assignees
@dsparacio
Labels
Bug
Milestone
2.0.0

Comments

@dsparacio
Copy link
Contributor

There was a recent commit for ratioDict that change getInitBitrate logic and broke the use of localStorage for last know bitrate.
@dsparacio
Copy link
Contributor Author

DOMStorage should only be used to access localStroage and not set init bitrate in ABR so logic is now moved to ABR Controller to check explicit settings first, then check if ratio, then check dom then set default if all other checks result in nan bitrate.

@dsparacio dsparacio added the Bug label Feb 3, 2016
@dsparacio dsparacio added this to the 2.0.0 milestone Feb 3, 2016
@dsparacio dsparacio self-assigned this Feb 3, 2016
dsparacio pushed a commit to dsparacio/dash.js that referenced this issue Feb 3, 2016
Fix for Dash-Industry-Forum#1088 and Fix for Dash-Industry-Forum#1115
d24e547
@dsparacio
Copy link
Contributor Author

Fixed in PR #1116

dsparacio pushed a commit that referenced this issue Feb 3, 2016
Merge pull request #1116 from AkamaiDASH/development
343d95b 
Fix for #1088 and Fix for #1115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsparacio dsparacio

Labels
Bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@dsparacio