fixes #5 "pause/play does not resume buffering"

Dash-Industry-Forum · Mar 13, 2014 · a54524e · a54524e
1 parent 484265d
commit a54524e
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/app/js/streaming/BufferController.js b/app/js/streaming/BufferController.js
@@ -302,7 +302,7 @@ MediaPlayer.dependencies.BufferController = function () {
                                                 rejectedBytes = null;
                                             }
 
-                                            if (!self.requestScheduler.isScheduled(self)) {
+                                            if (!self.requestScheduler.isScheduled(self) && isSchedulingRequired.call(self)) {
                                                 doStart.call(self);
                                             }
 
@@ -766,6 +766,13 @@ MediaPlayer.dependencies.BufferController = function () {
                 }
             }
         },
+
+        isSchedulingRequired = function() {
+            var isPaused = this.videoModel.isPaused();
+
+            return (!isPaused || (isPaused && this.scheduleWhilePaused));
+        },
+
 /*
         mseGetDesiredTime = function () {
             var ranges = buffer.buffered,
@@ -884,6 +891,11 @@ MediaPlayer.dependencies.BufferController = function () {
             checkIfSufficientBuffer.call(self);
             //mseSetTimeIfPossible.call(self);
 
+            if (!isSchedulingRequired.call(self) && !initialPlayback) {
+                doStop.call(self);
+                return;
+            }
+
             if (state === LOADING && bufferLevel < STALL_THRESHOLD) {
                 if (!stalled) {
                     self.debug.log("Stalling " + type + " Buffer: " + type);
@@ -976,6 +988,7 @@ MediaPlayer.dependencies.BufferController = function () {
         debug: undefined,
         system: undefined,
         errHandler: undefined,
+        scheduleWhilePaused: undefined,
 
         initialize: function (type, periodInfo, data, buffer, videoModel, scheduler, fragmentController, source) {
             var self = this,

diff --git a/app/js/streaming/MediaPlayer.js b/app/js/streaming/MediaPlayer.js
@@ -80,6 +80,7 @@ MediaPlayer = function (aContext) {
             streamController.load(source);
             system.mapValue("scheduleWhilePaused", scheduleWhilePaused);
             system.mapOutlet("scheduleWhilePaused", "stream");
+            system.mapOutlet("scheduleWhilePaused", "bufferController");
             system.mapValue("bufferMax", bufferMax);
             system.injectInto(this.bufferExt, "bufferMax");
         },

diff --git a/app/js/streaming/Stream.js b/app/js/streaming/Stream.js
@@ -496,6 +496,7 @@ MediaPlayer.dependencies.Stream = function () {
 
         onPlay = function () {
             this.debug.log("Got play event.");
+            startBuffering.call(this);
         },
 
         onPause = function () {
@@ -589,6 +590,15 @@ MediaPlayer.dependencies.Stream = function () {
             }
         },
 
+        startBuffering = function() {
+            if (videoController) {
+                videoController.start();
+            }
+            if (audioController) {
+                audioController.start();
+            }
+        },
+
         stopBuffering = function() {
             if (videoController) {
                 videoController.stop();