Update typings

Dash-Industry-Forum · Jun 19, 2019 · 6e18850 · 6e18850
1 parent 11c6af7
commit 6e18850
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 30 deletions.
diff --git a/index.d.ts b/index.d.ts
@@ -100,7 +100,6 @@ declare namespace dashjs {
             lowLatencyEnabled: boolean;
             keepProtectionMediaKeys: boolean;
             useManifestDateHeaderTimeSource: boolean;
-            segmentOverlapToleranceTime: number;
             useSuggestedPresentationDelay: boolean;
             manifestUpdateRetryInterval: number;
             liveCatchUpMinDrift: number;
@@ -247,7 +246,6 @@ declare namespace dashjs {
         setAutoPlay(value: boolean): void;
         getAutoPlay(): boolean;
         getDashMetrics(): DashMetrics;
-        getMetricsFor(type: 'video' | 'audio' | 'text' | 'stream'): MetricsList | null;
         getQualityFor(type: 'video' | 'audio' | 'image'): number;
         setQualityFor(type: 'video' | 'audio' | 'image', value: number): void;
         updatePortalSize(): void;
@@ -293,7 +291,6 @@ declare namespace dashjs {
         enableForcedTextStreaming(value: boolean): void;
         isTextEnabled(): boolean;
         getAverageThroughput(value: number): void;
-        keepProtectionMediaKeys(value: boolean): void;
         getSettings(): MediaPlayerSettingClass;
         updateSettings(settings: MediaPlayerSettingClass);
         resetSettings(): void;

diff --git a/samples/dash-if-reference-player/dashjs_config.json b/samples/dash-if-reference-player/dashjs_config.json
@@ -22,7 +22,6 @@
         "lowLatencyEnabled": false,
         "keepProtectionMediaKeys": false,
         "useManifestDateHeaderTimeSource": true,
-        "segmentOverlapToleranceTime": 0.2,
         "useSuggestedPresentationDelay": false,
         "manifestUpdateRetryInterval": 100,
         "liveCatchUpMinDrift": 0.02,

diff --git a/src/core/Settings.js b/src/core/Settings.js
@@ -255,22 +255,6 @@ function Settings() {
              * @memberof module:Settings.Schema
              */
             useManifestDateHeaderTimeSource: true,
-            /**
-             * The overlap tolerance time, at both the head and the tail of segments, considered when doing time to segment conversions.
-             *
-             * This is used when calculating which of the loaded segments of a representation corresponds with a given time position.
-             * Its value is never used for calculating the segment index in seeking operations in which it assumes overlap time threshold is zero.
-             *
-             * <pre>
-             * |-o-|--- segment X ----|-o-|
-             *                        |-o-|---- segment X+1 -----|-o-|
-             *                                                   |-o-|---- segment X+2 -----|-o-|
-             * </pre>
-             * @param {number} value
-             * @default 0.2 seconds.
-             * @memberof module:Settings.Schema
-             */
-            segmentOverlapToleranceTime: 0.2,
             /**
              * <p>Set to true if you would like to override the default live delay and honor the SuggestedPresentationDelay attribute in by the manifest.</p>
              * @param {boolean} value

diff --git a/test/unit/streaming.MediaPlayerSpec.js b/test/unit/streaming.MediaPlayerSpec.js
@@ -745,16 +745,6 @@ describe('MediaPlayer', function () {
             expect(LongFormContentDurationThreshold).to.equal(50);
         });
 
-        it('should configure setSegmentOverlapToleranceTime', function () {
-            let val = player.getSettings().streaming.segmentOverlapToleranceTime;
-            expect(val).to.equal(0.2);
-
-            player.updateSettings({'streaming': { 'segmentOverlapToleranceTime': 1.5 }});
-
-            val = player.getSettings().streaming.segmentOverlapToleranceTime;
-            expect(val).to.equal(1.5);
-        });
-
         it('should configure cacheLoadThresholds', function () {
             let cacheLoadThresholdForVideo = player.getSettings().streaming.cacheLoadThresholds[Constants.VIDEO];
             expect(cacheLoadThresholdForVideo).to.equal(50);