Skip to content

Commit

Permalink
fix DVRWindowSize manifest property (#3744)
Browse files Browse the repository at this point in the history
* fix DVRWindowSize manifest property

* Replace DVRWindowSize by dvrWindowSize
  • Loading branch information
bbert authored Aug 27, 2021
1 parent 07fc531 commit 4ff8a25
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1218,7 +1218,7 @@ declare namespace dashjs {
}

export interface IManifestInfo {
DVRWindowSize: number;
dvrWindowSize: number;
availableFrom: Date;
duration: number;
isDynamic: boolean;
Expand Down
2 changes: 1 addition & 1 deletion src/dash/DashAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -1071,7 +1071,7 @@ function DashAdapter() {
function convertMpdToManifestInfo(mpd) {
let manifestInfo = new ManifestInfo();

manifestInfo.DVRWindowSize = mpd.timeShiftBufferDepth;
manifestInfo.dvrWindowSize = mpd.timeShiftBufferDepth;
manifestInfo.loadedTime = mpd.manifest.loadedTime;
manifestInfo.availableFrom = mpd.availabilityStartTime;
manifestInfo.minBufferTime = mpd.manifest.minBufferTime;
Expand Down
4 changes: 2 additions & 2 deletions src/dash/vo/ManifestInfo.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
*/
class ManifestInfo {
constructor() {
this.DVRWindowSize = NaN;
this.dvrWindowSize = NaN;
this.loadedTime = null;
this.availableFrom = null;
this.minBufferTime = NaN;
Expand All @@ -44,4 +44,4 @@ class ManifestInfo {
}
}

export default ManifestInfo;
export default ManifestInfo;
2 changes: 1 addition & 1 deletion src/mss/MssHandler.js
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ function MssHandler(config) {

// Start MssFragmentInfoControllers in case of start-over streams
let manifestInfo = e.request.mediaInfo.streamInfo.manifestInfo;
if (!manifestInfo.isDynamic && manifestInfo.DVRWindowSize !== Infinity) {
if (!manifestInfo.isDynamic && manifestInfo.dvrWindowSize !== Infinity) {
startFragmentInfoControllers();
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/streaming/MediaPlayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -698,7 +698,7 @@ function MediaPlayer() {
if (!metric) {
return 0;
}
return metric.manifestInfo.DVRWindowSize;
return metric.manifestInfo.dvrWindowSize;
}

/**
Expand Down
2 changes: 1 addition & 1 deletion test/unit/streaming.controllers.StreamController.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ describe('StreamController', function () {

let staticStreamInfo = { manifestInfo: { isDynamic: false }, start: 10, duration: 600, id: '1' };
let dynamicStreamInfo = {
manifestInfo: { isDynamic: true, DVRWindowSize: 30, minBufferTime: 4 },
manifestInfo: { isDynamic: true, dvrWindowSize: 30, minBufferTime: 4 },
start: 10,
duration: Infinity,
id: '1'
Expand Down

0 comments on commit 4ff8a25

Please sign in to comment.