Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error with BOOL_SWITCH #343

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

danthe3rd
Copy link
Contributor

See also: https://stackoverflow.com/questions/55136414/constexpr-variable-captured-inside-lambda-loses-its-constexpr-ness

We had this sort of errors with nvcc 11.6:

$SRC_DIR/third_party/flash-attention/csrc/flash_attn/src/flash_fwd_launch_template.h(68): error: expression must have a constant value
Note #2767-D: the value of *this cannot be used as a constant
          detected during instantiation of "void run_mha_fwd_hdim64<T>(Flash_fwd_params &, cudaStream_t) [with T=cutlass::half_t]" 
$SRC_DIR/third_party/flash-attention/csrc/flash_attn/src/flash_fwd_hdim64_fp16_sm80.cu(25): here

@tridao tridao merged commit 31ae248 into Dao-AILab:main Jul 19, 2023
@tridao
Copy link
Member

tridao commented Jul 19, 2023

Thank you @danthe3rd!

@tmm1 tmm1 mentioned this pull request Jul 20, 2023
ziyuhuang123 pushed a commit to ziyuhuang123/flash-attention that referenced this pull request Jan 21, 2024
Fix compile error with `BOOL_SWITCH`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants