fix: in newer versions of triton, tl.dot should take as input only q … #1288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One can use the following minimal example to reproduce the problem:
In the original repository with recent versions of triton, we would get an error regarding the use of arg
trans_b
intl.dot
. In this PR, we fix the issue. The former example can now run properly. This triton implementation enables arbitrary masking through the argumentbias
.In order to test in colab, you add the following above the previous example to fix the current version of flash-attn