Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Invalid watch source" error if use vue-tweet in v-for #3

Closed
mahapo opened this issue Jun 1, 2022 · 3 comments · Fixed by #28
Closed

"Invalid watch source" error if use vue-tweet in v-for #3

mahapo opened this issue Jun 1, 2022 · 3 comments · Fixed by #28

Comments

@mahapo
Copy link

mahapo commented Jun 1, 2022

Using vue-tweet with v-for causing a "Invalid watch source".
image
@DannyFeliz
Copy link
Owner

This should be fixed here https://github.com/DannyFeliz/vue-tweet/releases/tag/v2.0.2

@mahapo
Copy link
Author

mahapo commented Jun 9, 2022

@DannyFeliz Issue still present. May changing props to ref would fix this. Like

watch(toRef(props), () => { renderTweet(); });

@DannyFeliz DannyFeliz reopened this Jul 1, 2022
DannyFeliz added a commit that referenced this issue Mar 29, 2024
@DannyFeliz
Watch props properly
add8b84 
Fix #3
@DannyFeliz DannyFeliz mentioned this issue Mar 29, 2024
Merged
@DannyFeliz
Copy link
Owner

DannyFeliz commented Mar 29, 2024 •
edited
Loading

@mahapo I fixed it on this PR #28, sorry for being almost 2 years late 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Watch property changes properly DannyFeliz/vue-tweet
2 participants
@DannyFeliz @mahapo