Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipe into certain new expressions #1678

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Fix pipe into certain new expressions #1678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions source/parser/pipe.civet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,8 @@ function constructInvocation(fn: ExprWithComments, arg: ASTNode!)
if lhs.type is "NewExpression"
{ expression } .= lhs
expression = {
...expression
type: "CallExpression"
children: [ ...expression.children, call ]
children: [ expression, call ]
}
{
...lhs
Expand Down
8 changes: 8 additions & 0 deletions test/pipe.civet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,14 @@ describe "pipe", ->
new Foo(x)(x)
"""

throws """
pipe to invalid new
---
x |> new .
---
ParseErrors: unknown:1:10 Partial placeholder . outside of call expression
"""

testCase """
pipe from new
---
Expand Down
Loading