Fix immediately called (op) in pipeline context
#1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edemaine
force-pushed
the
binary-op-unary-arg
branch
from
a295e94 to
66d8440
Compare
edemaine
changed the title
(op) called with single argument, in pipeline context(op) in pipeline context
STRd6
approved these changes
Jan 5, 2025
vendethiel
reviewed
Jan 5, 2025
| --- | ||
| foo |> (+) x | ||
| --- | ||
| (x)(foo) |
There was a problem hiding this comment.
Why is that the desired result?
There was a problem hiding this comment.
Oh, (+) x instantly unwraps, it’s not a section
There was a problem hiding this comment.
I'm not sure it's perfect, but the current behavior is that (+) can be followed by any number of arguments, and they get added together. In the special case of 1, it's not very useful, but maybe helpful in a setting where you're adding/removing arguments like so:
(+)
part1
part2
//edit from/to:
(+)
part1
//part2(similar to how we support empty blocks in if etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1672