Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implicit return of pipeline with return/throw #1676

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Fix implicit return of pipeline with return/throw #1676

merged 1 commit into from
Jan 5, 2025

Conversation

edemaine
Copy link
Collaborator

@edemaine edemaine commented Jan 5, 2025

Fixes #1675

edemaine
edemaine commented Jan 5, 2025
View reviewed changes
source/parser/pipe.civet
}, ")"],
}
returning = usingRef
for each s of gatherRecursiveAll statements, .type is "PipelineExpression"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the big diff; this is mostly just a dedentation.

@edemaine edemaine merged commit a9fd414 into main Jan 5, 2025
3 of 4 checks passed
@edemaine edemaine deleted the return-return branch January 5, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRd6 STRd6 STRd6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return at end of pipeline that causes return return if the pipeline was at the end of a function
2 participants
@edemaine @STRd6