Update to 2018 edition #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
repi
added a commit
to EmbarkStudios/physx-rs
that referenced
this pull request
Sep 14, 2019
The build-helper crate and repo has not been updated in 2 years and looks abandoned, and we have a long running PR for it (DanielKeep/rust-build-helper#2) with some dependency updates that haven't been merged in nor any communication about. So let's just remove the dependency and use explicit Cargo env vars and prinln instructions instead, easy enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates semver to its latest version, which was the original intent of the fork, but perhaps I went overboard with the rest of it and I can split that out into its own separate PR.