Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrictive upper bounds on pretty-show and temporary #59

Closed
ElvishJerricco opened this issue Oct 19, 2018 · 7 comments
Closed

Restrictive upper bounds on pretty-show and temporary #59

ElvishJerricco opened this issue Oct 19, 2018 · 7 comments

Comments

@ElvishJerricco
Copy link

These bounds are a little too strict: pretty-show >=1.8.1 && <1.9, temporary >=1.2.1 && <1.3. Pretty sure they can be bumped.

@ulidtko
Copy link
Collaborator

ulidtko commented Oct 19, 2018

This is pretty common situation in the Haskell package ecosystem.

You can try cabal install --allow-newer.

@ElvishJerricco
Copy link
Author

Yep, but a revision or something on Hackage would be nice.

@DanielG
Copy link
Owner

DanielG commented Oct 19, 2018

The latest pretty-show version is 1.8.2, which is in bounds, so I don't see your point?

I'd be happy to bump temporary to 1.3 though if you can confirm that the build succeeds with it.

@ElvishJerricco
Copy link
Author

@DanielG Ah, my bad. I'm building in nixpkgs, and pretty-show is actually beneath that version bound. Looks like it builds with 1.7. Should that be relaxed?

@DanielG
Copy link
Owner

DanielG commented Oct 24, 2018

Sure. Did you test with temporary 1.3 too?

@ElvishJerricco
Copy link
Author

I tested that it builds, but haven't actually run the test suite.

@langston-barrett
Copy link

In case anyone else finds this issue via trying to build a package that depends on this one with Nix, here's how to do it:

{ pkgsOld   ? import <nixpkgs> { }
, compiler  ? "ghc844"
}:

let
  config = {
    packageOverrides = pkgs: rec {
      haskellPackages =
        # builtins.trace (builtins.concatStringsSep "\n" (builtins.attrNames pkgs.haskell.packages))
        pkgs.haskell.packages."${compiler}".override {
        overrides = haskellPackagesNew: haskellPackagesOld: {
          cabal-helper = pkgs.haskell.lib.doJailbreak haskellPackagesOld.cabal-helper;
        };
      };
    };
  };
  pkgs = import <nixpkgs> { inherit config; };
in with pkgs; haskellPackages.callPackage ./default.nix { }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants