Fixed the TestbedApplication on case-sensitive systems, enable some warnings for g++ #10
Conversation
jagoly
changed the title
jagoly
changed the title
…gram (sign compare, those asserts, reorder constructors, etc.) - Removed the casting to (char*) for (void*) arguments to GL. Not sure why you were doing that?
…rectory, containing a reactphysics3d subdirectory, where the headers live. This greatly eases intergration of the library into other projects, as well as prevent naming confilcts. All reactphysics3d source and headers have been modified to use the new paths. The testbed application has not been changed, as this will not break existing client code. Fixed a couple of comments, formatting issues, etc that I happened to come across.
|
Hi, Thanks a lot for this pull request. I will check it when I have some time. For the moment, I prefer to work alone on the core physics engine code of ReactPhysics3D because it is quite time consuming to review pull requests from many people. At least until I have a very stable and complete physics library (version 1.0 maybe). However, I am really open to receive comments and sugestions about the core physics code but do not loose to much time working on this because I might not have the time to review all the pull requests. If you want to help on the project, I suggest you to work on things that are not related to the core physics engine. For instance, I really would like to have a plug-in to be able to integrate ReactPhysics3D in PEEL (the tool to evaluate and compare physics engines). I have just created a new issue for that here. This would be a component that is completely independant of the code I am currently working on and you can be responsible to implement this component if you want. If you are interested in working on this, let me know. |
|
Hmm, PEEL seems to be a windows only tool, unfortunately, thus I don't think I'd be able to write a plug-in for it. Regarding this pull, it doesn't touch any of the physics code, it's just a few clean ups that I made while setting the library up with my own project, which should make it easier for clients to setup. I figured it'd be worthwhile to push them to your repository, if you're interested. |
|
All good, I'll just maintain my own branch with these changes. |
I'm interested in helping with the project :)