-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch schema #33
Merged
Merged
Fetch schema #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…intainability by adding line breaks to long statements and improving code structure feat(index.d.ts): add new classes ClusterDataSimplified, KeyspaceSimplified, TableSimplified, MaterializedViewSimplified to provide simplified cluster and keyspace information feat(index.js): update exports to include new classes ClusterDataSimplified, KeyspaceSimplified, TableSimplified, MaterializedViewSimplified for better module organization and clarity feat(scylla_session.rs): add support for simplified data structures to improve readability and maintainability of the codebase. Signed-off-by: Felipi Lima Matozinho <[email protected]>
…ating keyspace and table feat(basic.mts): add support for fetching and displaying keyspace and table information feat(fetch-schema.mts): add new file to fetch and display keyspace and table information refactor(scylla_session.rs): restructure code to improve readability and maintainability by renaming structs and methods for better semantics and clarity. Update struct names to match their purpose and improve consistency in naming conventions. Signed-off-by: Felipi Lima Matozinho <[email protected]>
…r into feature/fetch-schema Signed-off-by: Felipi Lima Matozinho <[email protected]>
Daniel-Boll
requested changes
Jul 31, 2024
Remember to manually run |
…bility and error handling feat(session): add topology module to handle cluster topology information feat(session): move ScyllaClusterData struct to topology module for better organization and separation of concerns feat(topology.rs): add support for defining Scylla cluster data, keyspace, strategy, table, and materialized view structures to interact with Scylla database. Signed-off-by: Felipi Lima Matozinho <[email protected]>
Daniel-Boll
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.