-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable/redis-ha]: add redis source to restore options #296
[stable/redis-ha]: add redis source to restore options #296
Conversation
@hawwwdi Can we work through those inline changes your IDE has updated and undo them for now? Also, can you provide some logging showing a successful restore operation? Backups testing locally for me is a bit of a nightmare :) |
67bf680
to
4d03a7e
Compare
1e4a877
to
0644a73
Compare
0644a73
to
d95da19
Compare
@DandyDeveloper, I have fixed those inline changes and rolled them back. Additionally, I’ve made some changes to the restoration script: it is now only executed for the initial master instance and checks the connectivity of the provided Redis endpoint to prevent getting stuck in a crashLoopBackOff state in case of a pod restart. |
example logs of a successful restore operation:
redis instance:
|
@DandyDeveloper Could you please review this? |
@DandyDeveloper reminder |
I'll get it checked and if all good, I'll merge tomorrow! |
@hawwwdi I'll approved to get the test run but can you make this a minor rather than a patch? It's a big addition. The versioning should probably reflect this. |
I fixed it. |
What this PR does / why we need it:
This PR adds support for using a remote Redis instance as a data source for restoration. It utilizes the
redis-cli --rdb
command to perform the restore operation.[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)