Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress bar #345

Merged
merged 8 commits into from
Dec 3, 2024
Merged

Progress bar #345

merged 8 commits into from
Dec 3, 2024

Conversation

singularity-s0
Copy link
Collaborator

Closes #340

@singularity-s0 singularity-s0 enabled auto-merge (rebase) December 2, 2024 16:46
fsy2001
fsy2001 requested changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@fsy2001 fsy2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are various problems noted in comments. Moreover, you should try to find a more elegant way to do this, rather than pass the closure for 3 or 4 times.

Fudan Kit/Course/CourseModel.swift Outdated Show resolved Hide resolved
Fudan Kit/Course/GraduateCourseAPI.swift Outdated Show resolved Hide resolved
FudanUI/Pages/CoursePage.swift Outdated Show resolved Hide resolved
FudanUI/Pages/CoursePage.swift Outdated Show resolved Hide resolved
@singularity-s0
Copy link
Collaborator Author

should try to find a more elegant way to do this, rather than pass the closure for 3 or 4 times.

What is your suggestion?

@fsy2001
Copy link
Collaborator

fsy2001 commented Dec 2, 2024

Checkout TaskLocal.

fsy2001
fsy2001 requested changes Dec 3, 2024
View reviewed changes
View Utils/Async/AsyncContentView.swift Show resolved Hide resolved
FudanUI/Pages/CoursePage.swift Outdated Show resolved Hide resolved
FudanUI/Pages/CoursePage.swift Outdated Show resolved Hide resolved
@singularity-s0 singularity-s0 merged commit 43e1e8d into main Dec 3, 2024
@singularity-s0 singularity-s0 deleted the progress-bar branch December 3, 2024 12:24
@singularity-s0 singularity-s0 restored the progress-bar branch December 3, 2024 12:52
@singularity-s0 singularity-s0 deleted the progress-bar branch December 3, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsy2001 fsy2001 fsy2001 approved these changes

@ivanfei-1 ivanfei-1 Awaiting requested review from ivanfei-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

研究生课表加载进度条
2 participants
@singularity-s0 @fsy2001