Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: install snapserver from github, not from bullseye #74

Merged
merged 5 commits into from
Apr 20, 2023
Merged

feat: install snapserver from github, not from bullseye #74

merged 5 commits into from
Apr 20, 2023

Conversation

nis65
Copy link
Collaborator

@nis65 nis65 commented Apr 19, 2023

fixes #37
fixes #38

Daenou
Daenou approved these changes Apr 20, 2023
View reviewed changes
Copy link
Owner

@Daenou Daenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀. Not sold on the variable naming "_newest_pkg" as this doesn't tell the full story of installing it directly from github, but this is a nitpick and I leave it up to you if you want to change this.

@nis65
Copy link
Collaborator Author

nis65 commented Apr 20, 2023 •
edited
Loading

Thanks for the review. As discussed, I might change the name from snapserver_newest_pkg to snapserver_github_pkg. In addition, this gives me time to add an additional fix - I believe to have seen some duplicate files between that github package and the snapweb role (which is a dirty hack anyway).

@nis65 nis65 merged commit f3d1195 into main Apr 20, 2023
@nis65 nis65 deleted the githubpackage branch April 20, 2023 20:07
@nis65 nis65 changed the title feat: install newest snapserver github release feat: install snapserver from github, not from bullseye Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daenou Daenou Daenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detecting silence does not work New Snapclients are at 100% volume at first connect
2 participants
@nis65 @Daenou