Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor the code #14

Closed
Dadangdut33 opened this issue Jan 8, 2023 · 0 comments · Fixed by #15
Closed

refactor the code #14

Dadangdut33 opened this issue Jan 8, 2023 · 0 comments · Fixed by #15
Assignees
@Dadangdut33
Labels
enhancement New feature or request

Comments

@Dadangdut33
Copy link
Owner

The code here is somewhat messy actually

Would be a great idea to refactor the code and add some feature improvement
@Dadangdut33 Dadangdut33 added the enhancement New feature or request label Jan 8, 2023
@Dadangdut33 Dadangdut33 self-assigned this Jan 15, 2023
@Dadangdut33 Dadangdut33 moved this to In Progress in Roadmap Jan 15, 2023
Dadangdut33 added a commit that referenced this issue Jan 16, 2023
@Dadangdut33
capture #14
fb2490d
Dadangdut33 added a commit that referenced this issue Jan 16, 2023
@Dadangdut33
detached window #14
e4da967 
- rename filename typo in user manual
- add beep
- add version
- rename build file
Dadangdut33 added a commit that referenced this issue Jan 16, 2023
@Dadangdut33
about #14
42e0710 
- move some function to helper
- refactor jsonhandling and rename it to Json
- move tooltip to components
- move mbox to components
Dadangdut33 added a commit that referenced this issue Jan 16, 2023
@Dadangdut33
translator #14
ef617d4 
- also add some forgotten commit in the last one
- add logging
Dadangdut33 added a commit that referenced this issue Jan 16, 2023
@Dadangdut33
monitor info and get_offset #14
1a20f98
Dadangdut33 added a commit that referenced this issue Jan 17, 2023
@Dadangdut33
language code and globals class #14
ed100ad 
- update method still empty
Dadangdut33 added a commit that referenced this issue Jan 17, 2023
@Dadangdut33
log window #14
3d4d3c5
Dadangdut33 added a commit that referenced this issue Jan 17, 2023
@Dadangdut33
history window #14
fd3e00b
Dadangdut33 added a commit that referenced this issue Jan 17, 2023
@Dadangdut33
capture window #14
187d3dc 
- add reference of each window class to global class
- remove public.py (replaced with Globals.py)
- remove capture_windowsetting (this seems redundant so no need to refactor just remove it)
Dadangdut33 added a commit that referenced this issue Jan 17, 2023
@Dadangdut33
mask window #14
ab29059 
- bind keys
- add some color utils
- renamce some class
Dadangdut33 added a commit that referenced this issue Jan 17, 2023
@Dadangdut33
snipping #14
653a7c4 
- untested yet
- trying new method which is to select from static screenshotted img which will be loaded to canvas instead of just setting up mask on the screen
- improve monitor cache code
- move getscreentotalgeomtery
- add captureFullScreen function for the snipping mode
- rename the snipping file
Dadangdut33 added a commit that referenced this issue Jan 18, 2023
@Dadangdut33
setting offset #14
2afc923 
- rename component variables to clearer and shorter one
- setting not all done yet
Dadangdut33 added a commit that referenced this issue Jan 21, 2023
@Dadangdut33
setting window #14
0f1c757 
- add Tk type to each class master
- remove some typo
- add return status and msg to save partial setting
Dadangdut33 added a commit that referenced this issue Jan 23, 2023
@Dadangdut33
main window #14
038c873 
- add clear before insert
- save setting
- setting window layout still messy
- added initlogging to make clear possible
- rename some settings parameter and variables
- rename screentranslate.py to main.py
- fix bunch of stuff
- fix typo
- fix cbtn invoke
- havent tested the capture but other stuff works
- havent tested sync of setting ui and the other ui
@Dadangdut33 Dadangdut33 mentioned this issue Jan 24, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Jan 24, 2023
@Dadangdut33 Dadangdut33 pinned this issue Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dadangdut33 Dadangdut33

Labels
enhancement New feature or request
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2.0.0 refactor Dadangdut33/Screen-Translate
1 participant
@Dadangdut33