Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error page v2 #196

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Error page v2 #196

merged 7 commits into from
Jan 15, 2025

Conversation

TomDeeterink1
Copy link
Collaborator

Whats in the pull request?

Schermafbeelding 2025-01-07 131817

In this pull request u can find the components belonging to the error page

  • Homelink.svelte
  • Mainform.svelte

These are loaded in the following page:

  • error/page.svelte

Whats new in this pull request (V2)?

From the pull review i got feedback, i have converted this in to tickets.

I have completed the following tickets:

These are part of this bigger ticket:

Which tests have I conducted?

I went through our entire Definition of Done (DOD) and also tested the functionality.

Code

  • Your code adheres to the agreed conventions.
  • You consistently use tabs and line breaks.
  • Your code is structured with comments.
  • You explain complex code with comments.

Design

  • The completed component matches the design.

Responsiveness

  • It is responsive on all screens down to at least 300px wide.

Accessibility

  • It can be operated using a keyboard.
  • It has a clear focus state.
  • Semantic HTML is used (try to avoid using divs unnecessarily).
  • All buttons and other clickable elements have cursor: pointer.
  • You score at least 85% on Lighthouse for accessibility on both mobile and desktop.
  • Images, buttons, and links have alt tags that are short and clearly describe their purpose.
  • Your HTML passes the HTML validator.
  • It has been tested on multiple browsers, at least Firefox and Chrome.

Performance

  • All images have a standard height and width set in the HTML.
  • The format of each image is either webp or svg.
  • There is no unnecessary/duplicate code.
  • You achieve at least 85% on the performance Lighthouse test for both mobile and desktop.

Merging

  • All merge conflicts are resolved.
  • At least one person has reviewed and approved your code.

What needs to be tested?

  • I would like someone to double-check:
  • That all functionalities work.
  • That everything follows code conventions.
  • That I adhered to all DOD requirements.
  • Performance testing.
  • Lighthouse testing.

In deze eerste commit heb ik de structuur voor de folders bepaald. Ook heb ik de eerste atoom gemaakt. Dit is de "naar home" link.
In deze commit heb ik de form klaar gemaakt voor functionaliteit, het enige wat er nog moet gebeuren is een api koppeling zodat ik de data ook echt kan versturen
First push van de volledige sectie. Er moet nog wat werk gedaan worden. Maar dit is in principe de grote basis.
Een update aan de JS functie voor de form, deze werkt nu helemaal correct
In this commit i rewrote the js. and deleted unused code.

also i made sure the form works without js.

#179
In this commit i have changed al the css to the right code conventions.

Next up i will add BEM to my code, also i will fun a full refactor on my css

#183
In this commit i added BEM

#182
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lose-your-head-the-client-case ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:23am
lose-your-head-the-client-case-5q6r ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 0:23am

@OniWithTheHoodie OniWithTheHoodie merged commit 2bbbc30 into test-branch-01 Jan 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants