Fix waiting for new events (elastic#10593)

* Adding more syscalls to the whitelist in `libbeat` I have removed the seccomp policy of `journalbeat`. Four new syscalls has been added to the common policy instead: `fstatfs`, `getrlimit`, `ppoll` and `splice`. * Eliminate possible deadlock when closing the client * Previously, `journalbeat` was unable to read new entries from the journal after it has been started. Now it is fixed, and the reader code is much simpler now. * updated vendored `github.com/coreos/go-systemd/sdjournal` to latest release (no changes)
DStape · Feb 14, 2019 · 1dc58e0 · 1dc58e0
1 parent edc3d33
commit 1dc58e0
Show file tree

Hide file tree

Showing 8 changed files with 56 additions and 341 deletions.
diff --git a/CHANGELOG.next.asciidoc b/CHANGELOG.next.asciidoc
@@ -357,4 +357,6 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
 
 ==== Known Issue
 
+*Journalbeat*
 
+- Journalbeat requires at least systemd v233 in order to follow entries after journal changes (rotation, vacuum).
diff --git a/NOTICE.txt b/NOTICE.txt
@@ -241,8 +241,8 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 --------------------------------------------------------------------
 Dependency: github.com/coreos/go-systemd
-Version: v17
-Revision: 39ca1b05acc7ad1220e09f133283b8859a8b71ab
+Version: v18
+Revision: 9002847aa1425fb6ac49077c0a630b3b67e0fbfd
 License type (autodetected): Apache-2.0
 ./vendor/github.com/coreos/go-systemd/LICENSE:
 --------------------------------------------------------------------

diff --git a/journalbeat/include/seccomp_linux_386.go b/journalbeat/include/seccomp_linux_386.go
diff --git a/journalbeat/include/seccomp_linux_amd64.go b/journalbeat/include/seccomp_linux_amd64.go
diff --git a/journalbeat/input/input.go b/journalbeat/input/input.go
@@ -189,10 +189,10 @@ func (i *Input) publishAll() {
 
 // Stop stops all readers of the input.
 func (i *Input) Stop() {
-	i.client.Close()
 	for _, r := range i.readers {
 		r.Close()
 	}
+	i.client.Close()
 }
 
 // Wait waits until all readers are done.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -357,4 +357,6 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d

		==== Known Issue

		Journalbeat

		- Journalbeat requires at least systemd v233 in order to follow entries after journal changes (rotation, vacuum).