feature: add support for base dir #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGKevin
force-pushed
the
add-hostpath-support
branch
from
c2acb3a to
b075391
Compare
DSpeichert
requested changes
May 26, 2021
There was a problem hiding this comment.
Thank you for the contribution.
I'll be happy to accept a static/local handler feature. While it wasn't something I originally thought has place here, if it makes sense for you, it probably will make sense for others.
I do have some concerns about sanitization that are added inline.
BaseDir allows one to serve files that are stored on the host machine.
Sanitize user input by using Join. Join subsequently calls Clean.
OGKevin
force-pushed
the
add-hostpath-support
branch
from
b075391 to
c2011ea
Compare
OGKevin
commented
May 31, 2021
DSpeichert
requested changes
Jun 2, 2021
Co-authored-by: Daniel Speichert <[email protected]>
OGKevin
commented
Jun 4, 2021
OGKevin
force-pushed
the
add-hostpath-support
branch
from
4be3a4c to
544bf2f
Compare
DSpeichert
approved these changes
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseDir allows one to serve files that are stored on the host machine.