-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving the color contrast of home news content #3880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Tested this and it looks good, thank you @Andrea-Guevara!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Andrea-Guevara : Tested & reviewed this today. Overall, this works and looks good to me. However, there's a small code change that I'd recommend (see below). It's minor, but it avoids our SCSS files overwriting each other with different colors.
Once that change is made, I think this is ready to be merged.
Good morning @tdonohue, glad you noticed! Anything, we're at your disposal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @Andrea-Guevara ! This now looks good to me.
Successfully created backport PR for |
Successfully created backport PR for |
References
Description
Improved color contrast of home news content.
Instructions for Reviewers
List of changes in this PR:
Use an accessibility tool to see if the home news content is more accessible.
Checklist
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint
npm run check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.