Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of Google reCAPTCHA into DSpace Feedback Form #3101 #3369

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

VictorDuranEscire
Copy link
Contributor

Hi @tdonohue, I like to share this PR with you.

References

Description

Add rechaptcha's verification to feedback form.

URI URL: '/info/feedback'

Add rechaptcha verification to the feedback form to avoid mass comment requests.

Instructions for Reviewers

List of changes in this PR:

  • I have added a setting for the klaro plugin for the reCaptha cookie in the comment form.
  • I modified the google reCaptcha service to enable or disable the reCaptha cookie according to the settings on the back end.
  • I modified the feedback form to add the reCaptha component, I made the change similar to the registration component.
  • I added the messages for the cookie section and the feedback form with all available languages.

I recommend testing in an incognito tab of your browser.

Klaro cookies:

image

Error in the feedback form, button disabled when rejecting cookies:

image

Feedback form when accepting cookies settings:

image

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • [] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • [] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Copy link

Hi @VictorDuranEscire,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

Integration of Google reCAPTCHA into DSpace Feedback Form
4 participants