-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Bitstreams on edit-item-page doesn't work #3121
Remove Bitstreams on edit-item-page doesn't work #3121
Conversation
…& removed method calls retuning observables in edit collection's content source tab
…y-one_contribute-7.6' into w2p-113560_edit-item-add-relationships-one-by-one_contribute-7_x
While testing this PR I discovered that the discard & save buttons were not automatically disabled again after deleting a bitstream. I tested this on the |
Thanks @alexandrevryghem for the fix! |
Closing & reopening to reboot GitHub actions. (For some reason they didn't spin up properly with this PR.) |
@alexandrevryghem : Is there also a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks again @alexandrevryghem ! Tested this via #3127.. Verified this code is identical for 7.x.
References
Description
Fixed the issue on the edit bitstream tab from the item page, and also fixed the same kind of performance issues on the Content Source tab from edit collection.
Instructions for Reviewers
List of changes in this PR:
observableZip
with anobservableCombineLatest
because when you have multiple bundles, thethis.objectUpdatesService.hasUpdates
won't emit for all the bundles causing theobservableZip
not to emit and update it's value. By changing it to anobservableCombineLatest
even when one bundle has been changed the whole observable will update.Checklist
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.