-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created new custom search scope context #2657
base: main
Are you sure you want to change the base?
Created new custom search scope context #2657
Conversation
…' into w2p-108608_created-search-scope-selector_contribute-main # Conflicts: # src/app/core/shared/context.model.ts # src/app/shared/search-form/scope-selector-modal/scope-selector-modal.component.html # src/app/shared/search-form/scope-selector-modal/scope-selector-modal.component.ts
Hi @alexandrevryghem, |
…search-scope-selector_contribute-main # Conflicts: # src/app/shared/search-form/scope-selector-modal/scope-selector-modal.component.ts
@alexandrevryghem : Should this still be considered for 8.0? If so, could I ask you to update this PR on latest |
@tdonohue: I synced it with |
Hi @alexandrevryghem, |
a745cd4
to
196a8c2
Compare
Description
Currently the same search results is used for all the admin sidebar modals (create/edit Community/Collection/Item) and the search in scope modal. This PR adds an easy way to only modify the search results in one of those two types of modals by creating a new
Context.ScopeSelectorModal
&Context.ScopeSelectorModalCurrent
.Instructions for Reviewers
List of changes in this PR:
Context.ScopeSelectorModal
&Context.ScopeSelectorModalCurrent
DSOSelectorComponent
, if none is provided it will assume that you are using aContext.SideBarSearchModal
.SidebarSearchListElementComponent
and added a new@listableObjectComponent
decorator with the newly createdContext.ScopeSelectorModal
&Context.ScopeSelectorModalCurrent
. This way everything still works like it did before, but now it can also be customizedInclude guidance for how to test or review your PR.
CommunitySidebarSearchListElementComponent
in your themes but only add the decorators ofContext.ScopeSelectorModal
&Context.ScopeSelectorModalCurrent
All of DSpace
buttonChecklist
yarn lint
yarn check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.