#2055 MultiFrequencyTunerChannelSource Null Pointer Error On Channel … #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Source Shutdown - different solution to resolve possible memory leak with previous solution. Also fixes P25 issue where a traffic channel that doesn't get started is returned to the traffic channel pool.
DSheirer
force-pushed
the
2055-null-polyphase-channelizer-error
branch
from
fad1ea3 to
6edab7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2055 Rework the MultiFrequencyTunerChannelSource Null Pointer Error that was happening on startup where the channel rotation monitor was causing the channel to rotate to the next frequency and invoke stop on the current channel source before the channel had started, on some systems where the startup sequence takes a bit longer than normal.
Different solution to resolve possible memory leak with previous solution.
Also resolves issue introduced with #2068 with P25 traffic channel manager where a zero frequency value channel doesn't get started and the traffic channel wasn't being returned to the queue. This normally only impacts on startup when the P25 frequency bands hadn't yet been received.