#1939 Duplicate Call Detector Enhancements & Unit Tests #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSheirer
force-pushed
the
1939-duplicate-call-detection-tests
branch
from
7a78b1f to
596d101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1939
Enhances thread safety in the duplicate call detector.
Adds unit testing to test for common scenarios.
Adds checks for encrypted audio to remove audio segments that initially have decoded audio and then get flagged as encrypted with an encryption key to protect against scenarios where a call is simulcast with one call encrypted and the other call unencrypted, to avoid flagging as duplicate the unencrypted call audio.