#1966 P25 Aliases Not Correctly Matching Against Fully Qualified Radio & Talkgroup Values #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ully qualified talkgroup/radio values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1966
Resolves issue where P25 aliases were not correctly matching when radio system is using fully qualified (FQ) talkgroup/radio values.
The matching behavior was supposed to match:
However, a code logic error was stopping at step 1. Therefore any calls involving fully qualified users roaming onto the local system were not aliasing correctly unless the user had a fully qualified alias setup correctly.
This issue likely impacted users that had simple aliases setup for the locally assigned radio or talkgroup values and those aliases were no longer matching once the fully qualified radio and talkgroup values were being used by sdrtrunk.