Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1397 Decoding Channels Go IDLE After Period of Time #1407

Merged

Conversation

DSheirer
Copy link
Owner

Closes #1397

Resolves issue where decoding channels go IDLE after period of time. Isolated cause to a multi-threading issue where the polyphase channel manager receives notification that the tuner center frequency has changed and sets a flag to update each of the channels. This happens concurrent with a previous tuner center frequency change where the flag gets set and the second thread is updating the channel output processors with the previous frequency change and then unsets the frequency change flag, completely missing the second/latest frequency change update and causing the channels to all tune-out their desired signals as the tuner center frequency changes and the output channels continue mixing to the previous frequency.

Identified and resolved issue where a 2-stream polyphase synthesizer was being updated with an incorrectly designed synthesis filter which was causing massive droop on the second half of the reconstructed channel. Oddly enough, this didn't seem to impact the P25 decoders, but it may have impacted other decoding.

Identified and resolved issue with concurrent modification of the modules list in the processing chain associated with recent addition of the channel FFT view in the channel power tab, with a previous PR under this same issue.

…time. Isolated the cause to a multi-threading issue where the polyphase channel manager receives notification that the tuner center frequency has changed and sets a flag to update each of the channels. This happens concurrent with a previous tuner center frequency change where the flag gets set and the second thread is updating the output processors with the previous frequency change and then unsets the frequency change flag, completely missing the second/latest frequency change update and causing the channels to all tune-out their desired signals as the tuner center frequency changes and the output channels continue mixing to the previous frequency.

Identified and resolved issue where a 2-stream polyphase synthesizer was being updated with an incorrectly designed synthesis filter which was causing massive droop on the second half of the reconstructed channel.  Oddly enough, this didn't seem to impact the P25 decoders, but it may have impacted other decoding.

Identified and resolved issue with concurrent modification of the modules list in the processing chain associated with recent addition of the channel FFT view in the channel power tab.
@DSheirer DSheirer added this to the Build 0.5.1 milestone Jan 15, 2023
@DSheirer DSheirer self-assigned this Jan 15, 2023
@DSheirer DSheirer merged commit f0db286 into master Jan 15, 2023
@DSheirer DSheirer deleted the 1397-control-channels-go-idle-polyphase-channelizer branch January 15, 2023 09:13
@Waymorehoss
Copy link

i'm having problems with this my control channel will stay constant for a good while then it will stop and be idle after about 15 seconds it will go back to constant...does that mean something is wrong is it suppose to do that ?

@DSheirer
Copy link
Owner Author

This issue is resolved, so unless you're using an older version of sdrtrunk, it shouldn't be for this specific issue.

What you're describing sounds like your signal may be too weak and it may be fading in an out, or there may be a stronger signal nearby that's impacting it.

You can repost your question in one of the support forums if you need assistance in resolving it.

@Waymorehoss
Copy link

ok one other thing. i do think it's the signal strength that's causing it the control channel also will break in the waterfall feed do control channels do that take a break every now and then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control Channel Decode Goes to IDLE After Period of Time
2 participants