Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P25P1 Traffic Channel Allows Invalid Link Control Frequency Band Messages #2066

Closed
DSheirer opened this issue Oct 31, 2024 · 0 comments · Fixed by #2067
Closed

P25P1 Traffic Channel Allows Invalid Link Control Frequency Band Messages #2066

DSheirer opened this issue Oct 31, 2024 · 0 comments · Fixed by #2067
Assignees
@DSheirer
Labels
bug
Milestone
Version 0.6.1

Comments

@DSheirer
Copy link
Owner

sdrtrunk Version
master

Describe the bug
The P25 Phase 1 message processor is capturing all link control frequency band messages and applying them to the channels resulting in errant frequency values when the band message is invalid (ie doesn't pass CRC checks).
@DSheirer DSheirer added the bug label Oct 31, 2024
@DSheirer DSheirer added this to the Version 0.6.1 milestone Oct 31, 2024
@DSheirer DSheirer self-assigned this Oct 31, 2024
DSheirer pushed a commit that referenced this issue Oct 31, 2024
#2066 P25 Phase 1 frequency band link control messages are now checke…
93770d0 
…d for valid CRC before being used.
@DSheirer DSheirer mentioned this issue Oct 31, 2024
Merged
DSheirer added a commit that referenced this issue Oct 31, 2024
@DSheirer
#2066 P25 Phase 1 frequency band link control messages are now checke…
02e2362 
…d for valid CRC before being used. (#2067)

Co-authored-by: Dennis Sheirer <[email protected]>
@jkraemer21 jkraemer21 mentioned this issue Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DSheirer DSheirer

Labels
bug
Projects
None yet
Milestone
Version 0.6.1
Development

Successfully merging a pull request may close this issue.

#2066 P25 Phase 1 Frequency Band Link Control Messages Checked For Valid CRC DSheirer/sdrtrunk
1 participant
@DSheirer