Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDRTrunk not resetting JMBE IMBESynthesizer . #2040

Closed
tadscottsmith opened this issue Oct 24, 2024 · 1 comment · Fixed by #2048
Closed

SDRTrunk not resetting JMBE IMBESynthesizer . #2040

tadscottsmith opened this issue Oct 24, 2024 · 1 comment · Fixed by #2048
Assignees
Labels
Milestone

Comments

@tadscottsmith
Copy link
Collaborator

sdrtrunk Version
Latest nightly.

Describe the bug
SDTRunk is not resetting the IMBESynthesizer after each call.

Expected behavior
SDRTrunk should call the getAudioCodec().reset() function to reset the IMBEModelParameters on each new P25P1 call. Currently the IMBEModelParameters are being held across calls which is leading to a slight skew in audio quality, particularly at the beginning of a call.

Additional context
This does not seem to have a huge impact on overall audio quality, so feel free to close if you'd like. For testing purposes, I reset the parameters shortly after mEncryptedCallStateEstablished = true; in the P25P1AudioModule class, but I did not submit a PR since that might not be the ideal location for the code.

@DSheirer DSheirer self-assigned this Oct 27, 2024
@DSheirer DSheirer added this to the Version 0.6.1 milestone Oct 27, 2024
DSheirer pushed a commit that referenced this issue Oct 27, 2024
…r of last audio frame from previous call.
DSheirer added a commit that referenced this issue Oct 27, 2024
…r of last audio frame from previous call. (#2048)

Co-authored-by: Dennis Sheirer <[email protected]>
@tadscottsmith
Copy link
Collaborator Author

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants