Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P25 Phase 2 L3H Patch Groups - Extraneous Patched Talkgroups & Radios #1931

Closed
DSheirer opened this issue Jun 1, 2024 · 0 comments · Fixed by #1932
Closed

P25 Phase 2 L3H Patch Groups - Extraneous Patched Talkgroups & Radios #1931

DSheirer opened this issue Jun 1, 2024 · 0 comments · Fixed by #1932
Assignees
Labels
Milestone

Comments

@DSheirer
Copy link
Owner

DSheirer commented Jun 1, 2024

sdrtrunk Version

master

Describe the bug

The L3H group regroup explicit encryption message parsing is not using the message length information to determine how many talkgroups or radios are being included in the patch group and inadvertently including random octets from the subsequent message which is usually a null avoid zero bias message. This causes the patch group to show more talkgroups or radios than what is intended.

@DSheirer DSheirer added the bug label Jun 1, 2024
@DSheirer DSheirer added this to the Version 0.6.1 milestone Jun 1, 2024
@DSheirer DSheirer self-assigned this Jun 1, 2024
DSheirer pushed a commit that referenced this issue Jun 1, 2024
…ncorrectly includes Talkgroup/Radio identifiers incorrectly parsed from the subsequent message. Updated code to respect the self-reported message octet length and also to test for correct length before adding patch group member talkgroup and radio identifiers.
DSheirer added a commit that referenced this issue Jun 1, 2024
…ncorrectly includes Talkgroup/Radio identifiers incorrectly parsed from the subsequent message. Updated code to respect the self-reported message octet length and also to test for correct length before adding patch group member talkgroup and radio identifiers. (#1932)

Co-authored-by: Dennis Sheirer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant